Review Request 122197: Fixes to .ods import

Roman Shtemberko shtemberko at gmail.com
Thu Feb 5 12:10:50 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122197/
-----------------------------------------------------------

(Updated Фев. 5, 2015, 12:10 п.п.)


Review request for Calligra, Adam Pigg, Jarosław Staniek, Radosław Wicik, and Wojciech Kosowicz.


Bugs: 336815
    http://bugs.kde.org/show_bug.cgi?id=336815


Repository: calligra


Description
-------

Fix 336815 (path issue)
Also have fixed with this patch:
Check for an empty name.
Names are no more converted to the lower case (there is some conflicts with this behavior, imported tables can not be opened after this (only after restarting an app (!?)))
Check if name is not starting with a digit (conflicts with '_' at the begining as well).
Default name is added based on sheet selected.


Diffs (updated)
-----

  kexi/main/KexiMainWindow.cpp f499951 
  kexi/migration/AlterSchemaTableModel.h 2090b35 
  kexi/migration/AlterSchemaTableModel.cpp 86ef62e 
  kexi/migration/AlterSchemaWidget.h b29e7f9 
  kexi/migration/AlterSchemaWidget.cpp ea7fedd 
  kexi/migration/importtablewizard.h a0b4dca 
  kexi/migration/importtablewizard.cpp f3d02b9 
  kexi/plugins/migration/keximigrationpart.cpp 03c674e 
  kexi/widget/KexiConnectionSelectorWidget.cpp 48d3f7e 

Diff: https://git.reviewboard.kde.org/r/122197/diff/


Testing
-------


Thanks,

Roman Shtemberko

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150205/c6481352/attachment.htm>


More information about the calligra-devel mailing list