Review Request 122197: Fixes to .ods import

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122197/#review75359
-----------------------------------------------------------


Cool, much better!


kexi/migration/AlterSchemaWidget.h
<https://git.reviewboard.kde.org/r/122197/#comment52125>

    Getters like this shall be const.



kexi/migration/AlterSchemaWidget.h
<https://git.reviewboard.kde.org/r/122197/#comment52129>

    m_tableName suggest it's a QString. Propose to rename to m_tableNameWidget.



kexi/migration/AlterSchemaWidget.cpp
<https://git.reviewboard.kde.org/r/122197/#comment52128>

    No longer needed since m_tableName performs the conversion, am I right?



kexi/migration/AlterSchemaWidget.cpp
<https://git.reviewboard.kde.org/r/122197/#comment52131>

    When importing e.g. an empty ODS file m_newSchema->field(m_selectedColumn) can be NULL --> crash



kexi/migration/AlterSchemaWidget.cpp
<https://git.reviewboard.kde.org/r/122197/#comment52133>

    Why this? We want to give user possibility to enter name caption explicitly.


Extra issues:
- I changed caption/name to "abc" but the last page still shows: http://i.imgur.com/LAYuUll.png. That said, abc name is eventually used for the new table name.
- By the way: records should be counted from 1: http://i.imgur.com/BOC1yNA.png
- By the way: ... and the extra (3rd) record isn't necessary: http://i.imgur.com/BOC1yNA.png

- Jarosław Staniek


On Feb. 3, 2015, 1:26 p.m., Roman Shtemberko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122197/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 1:26 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg, Jarosław Staniek, Radosław Wicik, and Wojciech Kosowicz.
> 
> 
> Bugs: 336815
>     http://bugs.kde.org/show_bug.cgi?id=336815
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Fix 336815 (path issue)
> Also have fixed with this patch:
> Check for an empty name.
> Names are no more converted to the lower case (there is some conflicts with this behavior, imported tables can not be opened after this (only after restarting an app (!?)))
> Check if name is not starting with a digit (conflicts with '_' at the begining as well).
> Default name is added based on sheet selected.
> 
> 
> Diffs
> -----
> 
>   kexi/migration/AlterSchemaWidget.cpp ea7fedd 
>   kexi/migration/importtablewizard.h a0b4dca 
>   kexi/migration/importtablewizard.cpp f3d02b9 
>   kexi/widget/KexiConnectionSelectorWidget.cpp 48d3f7e 
>   kexi/migration/AlterSchemaWidget.h b29e7f9 
> 
> Diff: https://git.reviewboard.kde.org/r/122197/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Roman Shtemberko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150204/96801bf0/attachment.htm>