Review Request 122380: Improve undo/redo in Kexi form designer

[Roman Shtemberko]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122380/#review75308
-----------------------------------------------------------

Ship it!


Ship It!

- Roman Shtemberko


On Фев. 2, 2015, 2:07 п.п., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122380/
> -----------------------------------------------------------
> 
> (Updated Фев. 2, 2015, 2:07 п.п.)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Improve undo/redo in Kexi form designer
> 
> - properly change geometry property in property editor when resize handles are moved
> - do not display inline editor when re-doing "Insert widget" commands (usability fix)
> - don't create new commands when undoing color properties of widgets, so now undo/redo works as expected
> 
> Somehow related to https://git.reviewboard.kde.org/r/122042/.
> 
> Undo/redo for multiple widget selection is still broken but this is a TODO, and only colors can be changed for multiple selection so far anyway.
> 
> 
> Diffs
> -----
> 
>   kexi/formeditor/commands.cpp 0eb89070e8f77f99a9a466cb521af24f8d17a2ab 
>   kexi/formeditor/form.h 89937bc48fd7821eb22cfb45aaf4f6cc7f8ebbb8 
>   kexi/formeditor/form.cpp e1b4a6280c6c52db5370a3f0090be483ad0a74ab 
>   kexi/formeditor/form_p.cpp a6a277a583476e4c9a24d40d3124efc367d4babd 
>   kexi/formeditor/resizehandle.cpp f4e8b1e7c74f31cb6613caa1e042ada559389f62 
> 
> Diff: https://git.reviewboard.kde.org/r/122380/diff/
> 
> 
> Testing
> -------
> 
> Tested improvements with various widgets
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150203/3601c864/attachment.htm>