Review Request 126553: Fix GHNS build.

Matthew Dawson matthew at mjdsystems.ca
Wed Dec 30 06:23:32 GMT 2015



> On Dec. 30, 2015, 1:19 a.m., Boudewijn Rempt wrote:
> > I'm sure the change is fine, though I recommend everyone to build with GHNS disabled because it's too broken to be useful. Can you push the change yourself?

Indeed, I found this through Gentoo and I have a patch floating over there to disable it due to the warning from CMake.  I just figured upstreaming these changes would be good in case anyone cares to fix GHNS.  Thanks and pushed.


- Matthew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126553/#review90324
-----------------------------------------------------------


On Dec. 30, 2015, 1:21 a.m., Matthew Dawson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126553/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2015, 1:21 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This allows calligra to build when GHNS is enabled.
> 
> 
> Diffs
> -----
> 
>   krita/ui/widgets/kis_advanced_color_space_selector.cc 4d40b1f 
>   libs/widgets/CMakeLists.txt c9a84e7 
> 
> Diff: https://git.reviewboard.kde.org/r/126553/diff/
> 
> 
> Testing
> -------
> 
> Code now compiles.
> 
> 
> Thanks,
> 
> Matthew Dawson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20151230/520c8fe8/attachment.htm>


More information about the calligra-devel mailing list