Review Request 124883: Fix compilation of PsCommentLexer.cpp on platforms where char is unsigned

[Tom Hall]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124883/
-----------------------------------------------------------

(Updated Aug. 31, 2015, 11:48 a.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra.


Changes
-------

Submitted with commit 956bb80db4f300e4f8edeaf19d24fd61eb1932b2 by Friedrich W. H. Kossebau to branch master.


Repository: calligra


Description
-------

The C standard defines char to be either signed char or unsigned char. In this case, the char is used to store negative values to signify categories of characters as well as actual characters. Therefore it must be a signed char and doesn't work on platforms where char is unsigned (e.g. ARM). In this specific case, compilation of the file fails with:
> "error: narrowing conversion of '-127' from 'int' to 'char' inside { } [-Wnarrowing]".

There may be similar issues elsewhere where the char isn't inside initialiser braces, so it compiles successfully, but silently truncates or wraps the negative values.


Diffs
-----

  filters/karbon/eps/PsCommentLexer.cpp 6487df6 

Diff: https://git.reviewboard.kde.org/r/124883/diff/


Testing
-------


Thanks,

Tom Hall

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150831/47ffdfc3/attachment.htm>