Review Request 124508: Extending KoTextVisitor to handle table and cell visiting customly

[Soma Schliszka]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124508/#review83422
-----------------------------------------------------------



libs/kotext/KoTextEditor.cpp (line 427)
<https://git.reviewboard.kde.org/r/124508/#comment57664>

    We should use KoTextVisitor::Entirely here, or other words, I dont see why is Partly used in this case.
    
    Cell is not protected -> visit it from beging (to end I think...)


- Soma Schliszka


On July 29, 2015, 10:46 a.m., Soma Schliszka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124508/
> -----------------------------------------------------------
> 
> (Updated July 29, 2015, 10:46 a.m.)
> 
> 
> Review request for Calligra and Camilla Boemann.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> The KoTextVisitor is extended with two empty virtual functions. These will allow to perform custom operation when visiting a QTextTable or QTextTableCell object.
> 
> 
> Diffs
> -----
> 
>   libs/kotext/KoTextEditor.cpp c6e0976 
>   libs/kotext/KoTextEditor_p.h 93f7e67 
> 
> Diff: https://git.reviewboard.kde.org/r/124508/diff/
> 
> 
> Testing
> -------
> 
> Builded successfully, empty virtual functions so they do nothing during execution.
> 
> 
> Thanks,
> 
> Soma Schliszka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150804/0e3b8214/attachment.htm>