Review Request 123536: Always select design tab on entering to design mode.

Roman Shtemberko shtemberko at gmail.com
Tue Apr 28 15:42:08 BST 2015



> On Апрель 27, 2015, 8:18 п.п., Jarosław Staniek wrote:
> > Thanks for the efffort.
> > I need more info to undestand the patch. The original code works the same way as after your change when it comes to the steps 1..4 explained at https://bugs.kde.org/show_bug.cgi?id=335900

Design tab is activated properly (without this patch) if, in example, you leave report in design mode (with design tab activated), go to table in data mode and return to report (please, confirm if you have same behavior). However, the problem appears on swtiching design mode to data mode and returning back. Patch will make design tab being activated each time you switch to design mode (unless other tab was choosen on leaving).


- Roman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123536/#review79596
-----------------------------------------------------------


On Апрель 27, 2015, 3:57 п.п., Roman Shtemberko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123536/
> -----------------------------------------------------------
> 
> (Updated Апрель 27, 2015, 3:57 п.п.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Bugs: 335900
>     http://bugs.kde.org/show_bug.cgi?id=335900
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Fix for the [bug](https://bugs.kde.org/show_bug.cgi?id=335900)
> 
> 
> Diffs
> -----
> 
>   kexi/main/KexiMainWindow.cpp 532d3fb 
> 
> Diff: https://git.reviewboard.kde.org/r/123536/diff/
> 
> 
> Testing
> -------
> 
> Design tab is activated on switching to design mode, if no other tab was explicitly selected for this window & mode.
> 
> 
> Thanks,
> 
> Roman Shtemberko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150428/643a5893/attachment.htm>


More information about the calligra-devel mailing list