Review Request 123383: Saving-as Kexi object should close window of object that will be overwritten
Jarosław Staniek
staniek at kde.org
Sat Apr 25 23:26:31 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123383/#review79522
-----------------------------------------------------------
kexi/main/KexiMainWindow.cpp (line 2720)
<https://git.reviewboard.kde.org/r/123383/#comment54329>
closeWindow() can return false or cancelled too. In both cases I think we cannot continue.
- Jarosław Staniek
On April 23, 2015, 2:18 p.m., Roman Shtemberko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123383/
> -----------------------------------------------------------
>
> (Updated April 23, 2015, 2:18 p.m.)
>
>
> Review request for Calligra, Adam Pigg, Jarosław Staniek, Radosław Wicik, and Wojciech Kosowicz.
>
>
> Bugs: 344656
> http://bugs.kde.org/show_bug.cgi?id=344656
>
>
> Repository: calligra
>
>
> Description
> -------
>
> See [Bug 344656](https://bugs.kde.org/show_bug.cgi?id=344656)
>
>
> Diffs
> -----
>
> kexi/main/KexiMainWindow.cpp 532d3fb
>
> Diff: https://git.reviewboard.kde.org/r/123383/diff/
>
>
> Testing
> -------
>
> Window to be overwrited closes before actual overwriting.
>
>
> Thanks,
>
> Roman Shtemberko
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150425/d92d68be/attachment.htm>
More information about the calligra-devel
mailing list