Review Request 123486: Fix a bug when KoResourceItemChooser's current resource was resent on resize

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123486/#review79445
-----------------------------------------------------------

Ship it!


I'd prefer a commit per fix, but ship-it.

- Boudewijn Rempt


On April 24, 2015, 9:49 a.m., Dmitry Kazakov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123486/
> -----------------------------------------------------------
> 
> (Updated April 24, 2015, 9:49 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This patch fixes numerous bugs in KoResourceItemChooser
> 
> 1) Resizing the widged and then hide/show used to reset currently selected resource. That caused user's paintop presets and styles being invalidated by simply showing the widget on screen. Now this problem has gone, because the madoel()->reset() call is done in two stages with first saving the current selection and then restoring it when the reset is finished.
> 
> 2) Now the number of columns is calculated dynamically when the widget is being resized. Before the patch there was a weird behaviour: when resizing the widget the tiles were **scaled only**, and after the next hide/show the **number of columns** would be recalculated. Now both steps are executed simultaneously.
> 
> 3) The size of the preview splitter in KisPatternChooser is now fixed, so the user would see at least something :)
> 
> 
> Diffs
> -----
> 
>   libs/widgets/KoResourceModel.cpp 3b2f5e3 
>   libs/widgets/KoResourceModel.h 06a7135 
>   libs/widgets/KoResourceItemView.cpp e5d9e5a 
>   libs/widgets/KoResourceItemView.h 9b712ed 
>   libs/widgets/KoResourceItemChooser.cpp 6e5c349 
>   libs/widgets/KoResourceItemChooser.h e41bd26 
>   krita/ui/widgets/kis_pattern_chooser.cc 9568d3b 
> 
> Diff: https://git.reviewboard.kde.org/r/123486/diff/
> 
> 
> Testing
> -------
> 
> Tested in Krita only
> 
> 
> Thanks,
> 
> Dmitry Kazakov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150424/a6a319ac/attachment.htm>