Review Request 123460: No need for Karbon to register a path for resource type "kis_brushes", right?

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123460/
-----------------------------------------------------------

(Updated April 23, 2015, 7:11 a.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra, Yue Liu and Boudewijn Rempt.


Changes
-------

Submitted with commit b54c2205628ef9de19e9b34f49ea5720cd5f5f3b by Friedrich W. H. Kossebau to branch calligra/2.9.


Repository: calligra


Description
-------

Karbon has `s_instance->dirs()->addResourceType("kis_brushes", "data", "krita/brushes/");`. Seems like that registration is there forever. But in current code I cannot see how Karbon could make use of brushes. And at least all code using such resource types is in krita/libbrush/kis_brush_server.cpp, so should be also self-contained.

Might have missed something, so asking the experts if this is really a bogus registration.


Diffs
-----

  karbon/ui/KarbonFactory.cpp 464bb0a 

Diff: https://git.reviewboard.kde.org/r/123460/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150423/cdcbb3cd/attachment.htm>