Review Request 123471: Kexi: MapBrowser: Improved properties for forms and reports
Radosław Wicik
radoslaw at wicik.pl
Wed Apr 22 23:40:29 BST 2015
> On Kwi 22, 2015, 11:36 po południu, Jarosław Staniek wrote:
> > kexi/plugins/forms/widgets/mapbrowser/MapBrowserWidget.cpp, line 37
> > <https://git.reviewboard.kde.org/r/123471/diff/1/?file=362540#file362540line37>
> >
> > Please explain in a comment here, why is remembering this values needed.
It was experiment, I thought that marble on start detects current geographical position and that it starts ther,
but it doesn't. I'll remove latitude and logitude, zoom ~= 1200 you see more or less entire earth
- Radosław
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123471/#review79356
-----------------------------------------------------------
On Kwi 22, 2015, 10:57 po południu, Radosław Wicik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123471/
> -----------------------------------------------------------
>
> (Updated Kwi 22, 2015, 10:57 po południu)
>
>
> Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Jarosław Staniek, and Dimitrios Tanis.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> Kexi: MapBrowser: Improved properties for forms and reports
>
>
> Diffs
> -----
>
> kexi/plugins/forms/widgets/mapbrowser/MapBrowserFactory.h d8f9da52ed8814c35b1013f909940e50cf9b2383
> kexi/plugins/forms/widgets/mapbrowser/MapBrowserFactory.cpp c86462ea5fa6663351687ab4a26c9c853b450d05
> kexi/plugins/forms/widgets/mapbrowser/MapBrowserWidget.h ffaea65f0be222373ec84a93c26e96b53bd03fc1
> kexi/plugins/forms/widgets/mapbrowser/MapBrowserWidget.cpp df9ad7ea25c37a084d69019a9d4fcb6c22a11fdf
> libs/koproperty/editors/spinbox.cpp 17638610389773174461f6ff63fcae08aa4f2d95
> plugins/reporting/maps/KoReportItemMaps.cpp c862655006b9f8423be48f1eafa053573dd1f06b
>
> Diff: https://git.reviewboard.kde.org/r/123471/diff/
>
>
> Testing
> -------
>
> Manual testing
>
>
> Thanks,
>
> Radosław Wicik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150422/ffb894cd/attachment.htm>
More information about the calligra-devel
mailing list