Review Request 123432: Replace klocale.h with KLocalizedString
Jarosław Staniek
staniek at kde.org
Wed Apr 22 23:35:54 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123432/#review79365
-----------------------------------------------------------
Ship it!
A good fix for now. I propose to convert the code to QObject::tr() afterwards if you're interested in dragging this further.
- Jarosław Staniek
On April 20, 2015, 2:27 a.m., Kamil Łysik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123432/
> -----------------------------------------------------------
>
> (Updated April 20, 2015, 2:27 a.m.)
>
>
> Review request for Calligra, Andrius da Costa Ribas, Friedrich W. H. Kossebau, Adam Pigg, Roman Shtemberko, Jarosław Staniek, Radosław Wicik, and Wojciech Kosowicz.
>
>
> Repository: kreport
>
>
> Description
> -------
>
> Replace klocale.h with KLocalizedString
>
>
> Diffs
> -----
>
> src/common/KoReportItemBase.cpp fae4616
> src/common/KoUnit.cpp 8b00648
> src/common/krpos.cpp 00a723b
> src/common/krsize.cpp 8e1463b
> src/plugins/chart/KoReportItemChart.cpp b8df8cb
> src/wrtembed/KoRuler.cpp 927d58e
> src/wrtembed/KoZoomMode.cpp 0c69d07
> src/wrtembed/reportpropertiesbutton.cpp 95e129d
>
> Diff: https://git.reviewboard.kde.org/r/123432/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kamil Łysik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150422/b7f76ca7/attachment.htm>
More information about the calligra-devel
mailing list