Review Request 123407: Avoid potential crashes in Kexi name dialog: do not store pointer unless really needed

Adam Pigg adam at piggz.co.uk
Sun Apr 19 23:44:55 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123407/#review79226
-----------------------------------------------------------

Ship it!


Ship It!

- Adam Pigg


On April 17, 2015, 9:08 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123407/
> -----------------------------------------------------------
> 
> (Updated April 17, 2015, 9:08 p.m.)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, Kamil Łysik, Friedrich W. H. Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Avoid potential crashes: do not store pointer unless really needed
> 
> (possible future issue: reference to temporary)
> 
> 
> Diffs
> -----
> 
>   kexi/widget/KexiNameDialog.cpp 09355d0032512f70a663c990203fc2b1117d9bdd 
> 
> Diff: https://git.reviewboard.kde.org/r/123407/diff/
> 
> 
> Testing
> -------
> 
> unchanged behaviour
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150419/a761ad4a/attachment.htm>


More information about the calligra-devel mailing list