Review Request 123226: Fix logic for adding new records for Kexi tables and forms

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123226/
-----------------------------------------------------------

(Updated April 20, 2015, 12:30 a.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra, Andrius da Costa Ribas, Kamil Łysik, Friedrich W. H. Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz.


Bugs: 345210
    http://bugs.kde.org/show_bug.cgi?id=345210


Repository: calligra


Description
-------

Fix logic for adding new records for Kexi tables and forms

- recently we allow editing to start in a row different than the current row, for this we need to remember which row is being edited, not just if the current row is edited
- the above is used by a feature that first starts editing a row (e.g. the last) and only after that moves the cursor (animations are possible this way)
- fixed buffered changes in edited record, otherwise saving did not work properly
- added sanity checks for cases when editing of a row is requested but editing of other row was not accepted/cancelled

for 2.9.3


Diffs
-----

  kexi/plugins/forms/kexiformscrollview.h 306ffe6dfa16ed34f2f757538afdedec0520633e 
  kexi/plugins/forms/kexiformscrollview.cpp 1ea54670835e352d2f916ecbe824127d6d1db3f2 
  kexi/widget/dataviewcommon/kexidataawareobjectiface.h 73fc84dfb5578a6d7752c7ea86a13127473a0879 
  kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp 0a388059222737d0d53778b703ac7f1c03b5464c 
  kexi/widget/dataviewcommon/kexidataawareview.cpp 973d4e6ddf0fb8cd5348034f05e6d2ffa7c80897 
  kexi/widget/tableview/KexiTableScrollArea.cpp 2e162786aa1d8366d7480c2aa298c75988993843 
  kexi/widget/tableview/KexiTableScrollAreaHeaderModel.cpp 55b381077e50bcc52a40f7b7cc6b2aeb338e5c4c 

Diff: https://git.reviewboard.kde.org/r/123226/diff/


Testing
-------

Tested with table views and form; now multiple clicking the "+ Go to new record" button in the record navigator adds multiple records as expected; any other editing works too like before.


Thanks,

Jarosław Staniek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150419/11becb6a/attachment.htm>