Review Request 123392: Better do not use "appdata" with KStandardDirs in plugins/parts
Friedrich W. H. Kossebau
kossebau at kde.org
Sat Apr 18 12:38:19 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123392/
-----------------------------------------------------------
(Updated April 18, 2015, 11:38 a.m.)
Status
------
This change has been marked as submitted.
Review request for Calligra, Tomas Mecir and Boudewijn Rempt.
Changes
-------
Submitted with commit 432864d54cf5b0b6a338276d876b1e8572c90d31 by Friedrich W. H. Kossebau to branch calligra/2.9.
Repository: calligra
Description
-------
"appdata" gets resolved to "share/appname" with KStandardDirs. And `appname` will be the name of the KApplication app, whatever that is. So with plugins one better uses "data" and explicitely writes the prefix of the respective program (or plugin) whose data/resources should be accessed.
See "A type that is added by the class KApplication" etc. in
http://api.kde.org/4.x-api/kdelibs-apidocs/kdecore/html/classKStandardDirs.html
This patch changes most usages of "appdata" to "data". From a quick test Krita and Sheets still seem to work for what got changed (Krita Sketch and Krita Gemini not yet tested for what is possible).
Those usages with `KoScript*` classes I did not touch (yet), as there potentially things should be resolved relative to the real app (not investigated further so far, so no clue).
Diffs
-----
krita/crashreporter/mainwindow.cpp eff5516
krita/plugins/extensions/resourcemanager/resourcebundle.cpp e5aacad
krita/ui/input/config/kis_input_configuration_page.cpp a1d34c9
krita/ui/input/kis_input_profile_manager.cpp 84222d2
sheets/ui/CellToolBase.cpp 4d5db5e
Diff: https://git.reviewboard.kde.org/r/123392/diff/
Testing
-------
Thanks,
Friedrich W. H. Kossebau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150418/97f8c6cb/attachment.htm>
More information about the calligra-devel
mailing list