Review Request 123383: Saving-as Kexi object should close window of object that will be overwritten

[Jarosław Staniek]

> On April 16, 2015, 7:14 p.m., Jarosław Staniek wrote:
> > Works! But... wouldn't it be simple to just use KexiProject::item(KexiPart::Info *i, const QString &name) in getNewObjectInfo() where name is originalName?

I was also wondering if the same applies to my code in KexiNameDialog::canOverwrite(): 
KexiProject::item(KexiPart::Info *i, const QString &name) could be used there too instead of loadObjectSchemaData().
But there we want to check if object with give name exists in the project's db, not just in memory. So keeping the use of loadObjectSchemaData() there covers the case when other instance of Kexi created object with this name. 
(please correct me if that's wrong)


- Jarosław


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123383/#review79065
-----------------------------------------------------------


On April 16, 2015, 4:07 p.m., Roman Shtemberko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123383/
> -----------------------------------------------------------
> 
> (Updated April 16, 2015, 4:07 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg, Jarosław Staniek, Radosław Wicik, and Wojciech Kosowicz.
> 
> 
> Bugs: 344656
>     http://bugs.kde.org/show_bug.cgi?id=344656
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> See [Bug 344656](https://bugs.kde.org/show_bug.cgi?id=344656)
> 
> 
> Diffs
> -----
> 
>   kexi/main/KexiMainWindow.cpp 532d3fb 
>   kexi/widget/KexiNameDialog.h 143f917 
>   kexi/widget/KexiNameDialog.cpp 09355d0 
> 
> Diff: https://git.reviewboard.kde.org/r/123383/diff/
> 
> 
> Testing
> -------
> 
> Window to be overwrited closes before actual overwriting.
> 
> 
> Thanks,
> 
> Roman Shtemberko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150416/aa48ffcc/attachment.htm>