Review Request 122867: Replace deprecated strstream classes with sstreams in Quattro Pro filter

Robert Mathias Marmorstein robert at narnia.homeunix.com
Thu Apr 16 15:44:02 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122867/
-----------------------------------------------------------

(Updated April 16, 2015, 2:44 p.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra.


Repository: calligra


Description
-------

The strstream class has been deprecated for some time in favor of the sstream classes.  This patch replaces strstream with sstreams.


Diffs
-----

  filters/sheets/qpro/libqpro/src/formula.cc c5d6021 
  filters/sheets/qpro/libqpro/src/record.cc bde5e7d 
  filters/sheets/qpro/libqpro/src/stream.cc 4126aee 

Diff: https://git.reviewboard.kde.org/r/122867/diff/


Testing
-------

After the change calligra compiles and passes the same unit tests as before.  Unfortunately, I don't have any qpro files lying around to test this on.


Thanks,

Robert Mathias Marmorstein

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150416/23e3c645/attachment.htm>


More information about the calligra-devel mailing list