Review Request 115110: Modify vc-based macros to allow passing flags.

Andrius da Costa Ribas andriusmao at gmail.com
Thu Apr 16 12:50:06 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115110/
-----------------------------------------------------------

(Updated April 16, 2015, 11:50 a.m.)


Status
------

This change has been discarded.


Review request for Calligra and kdewin.


Repository: calligra


Description
-------

This was needed because the generated object files are not generated as part of the shared lib target, having not defined the -DMAKE_XXXX_LIB that is automatically defined by CMake otherwise.


Diffs
-----

  CMakeLists.txt 62f8e79 
  krita/image/CMakeLists.txt eefaf61 
  libs/pigment/CMakeLists.txt 0073377 

Diff: https://git.reviewboard.kde.org/r/115110/diff/


Testing
-------

Tested building on both MSVC and MinGW


Thanks,

Andrius da Costa Ribas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150416/76ddb2a2/attachment.htm>


More information about the calligra-devel mailing list