Review Request 123352: Fix DockerStylesComboModel

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123352/#review79027
-----------------------------------------------------------

Ship it!


Ship It!

- Friedrich W. H. Kossebau


On April 16, 2015, 3:43 vorm., Thorsten Zachmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123352/
> -----------------------------------------------------------
> 
> (Updated April 16, 2015, 3:43 vorm.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This patch fixes the style combo box showing the wrong name for a style after adding a style.
> 
> To reproduce the problem:
> 
> Create a new stage document (Template Screen Empty):
> Add a text shape
> Write one line of text
> Assign the text the paragraph style Standard.
> Change to center alignment.
> Use the plus button in the paragraph style to assign it the new name S2.
> Change the alignment to right.
> Use the plus button in the paragraph style to assign it the new name S1.
> 
> Now open the combobox and scroll to the top. It will show 3 times S1.
> The problem is that the index in the StylesModel is changed but not index in the DockerStylesComboModel.cpp mapping.
> Therefor all 3 styles pointing to the same index.
> 
> As the model is recreated all the time it just also newly creates the mapping simplifying the code in doing so.
> It also changes the magic -1 to be a Constant.
> 
> 
> Diffs
> -----
> 
>   plugins/textshape/dialogs/DockerStylesComboModel.cpp 409a9f1 
>   plugins/textshape/dialogs/StylesModel.h d15651f 
>   plugins/textshape/dialogs/StylesModel.cpp f996824 
> 
> Diff: https://git.reviewboard.kde.org/r/123352/diff/
> 
> 
> Testing
> -------
> 
> Tested adding of various style with different names. Worked quite nicly
> 
> 
> Thanks,
> 
> Thorsten Zachmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150416/847cb380/attachment.htm>