Review Request 123286: Complete the move of the Pivot Tables into Sheets and also remove the old plugin in staging

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123286/
-----------------------------------------------------------

(Updated April 15, 2015, 8:11 p.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra, Tomas Mecir and Jigar Raisinghani.


Changes
-------

Submitted with commit 98eb29313aa84ace765032b54c20520420f1c1cb by Friedrich W. H. Kossebau to branch calligra/2.9.


Repository: calligra


Description
-------

Seems that in f7e9c2f7955a19ccf657f321f93d2f1ec6a1ea97 the Pivot tables plugin was integrated into Sheets, but without also deleting the plugin from `plugins/staging/pivottables`.

Attached patch does that. But as I have no real clue and might have missed something, Jigar, please tell if I got that correctly and applying this patch is correct.


Diffs
-----

  CalligraProducts.cmake 588155f 
  plugins/staging/CMakeLists.txt 0e0c88e 
  plugins/staging/pivottables/CMakeLists.txt 6972fbb 
  plugins/staging/pivottables/Messages.sh e0bb4f2 
  plugins/staging/pivottables/pivot.h baf5c8a 
  plugins/staging/pivottables/pivot.cpp c9141b8 
  plugins/staging/pivottables/pivot.ui 0256690 
  plugins/staging/pivottables/pivotfilters.h 1e2bfc9 
  plugins/staging/pivottables/pivotfilters.cpp 9db7908 
  plugins/staging/pivottables/pivotfilters.ui cb7c567 
  plugins/staging/pivottables/pivotmain.h a2fa033 
  plugins/staging/pivottables/pivotmain.cpp aef13cf 
  plugins/staging/pivottables/pivotmain.ui 3471394 
  plugins/staging/pivottables/pivotoptions.h f146735 
  plugins/staging/pivottables/pivotoptions.cpp 0eeed1b 
  plugins/staging/pivottables/pivotoptions.ui 1abf2c8 
  plugins/staging/pivottables/pivotplugin.h ec94610 
  plugins/staging/pivottables/pivotplugin.cpp 3ef23a7 
  plugins/staging/pivottables/pivotsubtotals.h 66cd361 
  plugins/staging/pivottables/pivotsubtotals.cpp 8884b38 
  plugins/staging/pivottables/pivotsubtotals.ui c02c9dd 
  plugins/staging/pivottables/pivottables.rc b054985 
  plugins/staging/pivottables/sheetspivottables.desktop e65c294 

Diff: https://git.reviewboard.kde.org/r/123286/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150415/6d41f2c7/attachment.htm>