Review Request 123347: Remove unused registration of resource type "kis_shaders"

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123347/#review78896
-----------------------------------------------------------

Ship it!


Ship It!

- Boudewijn Rempt


On April 12, 2015, 10:04 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123347/
> -----------------------------------------------------------
> 
> (Updated April 12, 2015, 10:04 p.m.)
> 
> 
> Review request for Calligra, Dmitry Kazakov and Boudewijn Rempt.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> While "kis_shaders" is registered as resource type and that path, any shader is actually fetched via the "data" resource type, from what I found. Which is not a problem, but makes that "kis_shaders" resource type unneeded. Also in Qt5 there is no way to define own resource types (no such concept in QStandardPaths), with KStandardDirs' "data" being mappable to an equivalent in QStandardPaths, so rather future-proof and no sense to change all places to use "kis_shaders".
> 
> Thus I propose to remove this unused registration, to clean the sources from anything that results only in unneeded thinking during porting. And to save 4 cycles on start-up for 2.9 ;)
> 
> I might have overlooked something, so going via a RR :)
> 
> 
> Diffs
> -----
> 
>   krita/ui/kis_factory2.cc c24d77f 
> 
> Diff: https://git.reviewboard.kde.org/r/123347/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150413/3ed4117c/attachment.htm>