Review Request 123338: Fix showing only an empty list of palettes in Karbon's palette bottom bar

[Sven Langkamp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123338/#review78853
-----------------------------------------------------------

Ship it!


Ship It!

- Sven Langkamp


On April 11, 2015, 7:35 nachm., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123338/
> -----------------------------------------------------------
> 
> (Updated April 11, 2015, 7:35 nachm.)
> 
> 
> Review request for Calligra, Sven Langkamp and Yue Liu.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> The palette bar below the canvas view in Karbon no longer shows a palette for me. And the menu in the popup with palettes to select from is empty.
> 
> Seems this is because a KoResourceServerAdapter needs to explicitely called `connectToResourceServer()` on to make it listen to changes in the resourceserver. This seems to be like that forever (2007, see 6603f52fa974ae5ec85f9112a1b74bb1b7f05fe6). I could not find what has changed there recently that broke things.
> 
> Attached patch restores the old behaviour again for me, having the list of all installed palettes in the menu of the bar, and one preloaded.
> 
> 
> Diffs
> -----
> 
>   karbon/ui/widgets/KarbonPaletteBarWidget.cpp 255fe87 
> 
> Diff: https://git.reviewboard.kde.org/r/123338/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150412/38f4a3ee/attachment.htm>