Review Request 123340: Remove unneeded resource type setting for s_componentData->componentName() + "data"

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123340/#review78841
-----------------------------------------------------------

Ship it!


Yep, you're not using that.

git grep locate | grep data'"' | grep -v '"data"'

And indeed there is very little value in being able to write
    KStandardDirs::locate("stagedata", "templates/exportHTML/toc.html")
instead of
    KStandardDirs::locate("data", "stage/templates/exportHTML/toc.html")

- David Faure


On April 11, 2015, 11:02 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123340/
> -----------------------------------------------------------
> 
> (Updated April 11, 2015, 11:02 p.m.)
> 
> 
> Review request for Calligra, David Faure and Boudewijn Rempt.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> When copying over KPart code into Calligra, during the dekpartification, also lines for registering a resourcetype componentName() + "data" were copied.
> From what I understood this behaviour is not needed at all, at least in Calligra.
> And from reading http://marc.info/?l=kde-commits&m=98328741017209&w=2 it seems it really was just a random idea that never turned into something really useful, which is also why it now traceless seems to have disappeared from KParts in KF5.
> Can you confirm, David?
> 
> 
> Diffs
> -----
> 
>   krita/ui/kis_factory2.cc 2f5ba41 
>   libs/main/KoPart.cpp 0cc5658 
> 
> Diff: https://git.reviewboard.kde.org/r/123340/diff/
> 
> 
> Testing
> -------
> 
> All Calligra apps still start fine, no problems seen.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150411/76b58935/attachment.htm>