Review Request 123315: Merge filter desktop files for some Karbon import/export filters

[Yue Liu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123315/#review78782
-----------------------------------------------------------

Ship it!


Ship It!

- Yue Liu


On April 9, 2015, 11:27 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123315/
> -----------------------------------------------------------
> 
> (Updated April 9, 2015, 11:27 p.m.)
> 
> 
> Review request for Calligra and Yue Liu.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> The SVG->Karbon filter supports both SVG and compressed SVG. Instead of having one desktop file for the filter listing both mimetypes in the `X-KDE-Import` entry (which is a stringlist with `,` as separator), there are two separate desktop files.
> Same with the Karbon->Image (PNG,JPEG) filter, instead of listing both supported mimetypes in the `X-KDE-Export` entry, there are two separate desktop files.
> Which is fine in the current world where metadata about filters is stored in separate desktop files. There can be multiple desktop files per binary plugin.
> 
> But in the new world in the `frameworks` branch, metadata about filters is stored embedded (in JSON format) in the actual binary plugin. Which also means there can be only one metadata bundle per filter.
> 
> To prepare the new world, I propose to merge the desktop files already in the 2.9 branch, so it is closer to the needs of the new world, and merging branches is less in danger of conflicts.
> 
> 
> Diffs
> -----
> 
>   filters/karbon/image/CMakeLists.txt 785527f 
>   filters/karbon/image/calligra_filter_karbon2image.desktop PRE-CREATION 
>   filters/karbon/image/calligra_filter_karbon2jpg.desktop a925282 
>   filters/karbon/image/calligra_filter_karbon2png.desktop 628063c 
>   filters/karbon/svg/CMakeLists.txt fc5bb40 
>   filters/karbon/svg/calligra_filter_svg2karbon.desktop 48a3316 
>   filters/karbon/svg/calligra_filter_svgz2karbon.desktop 107298c 
> 
> Diff: https://git.reviewboard.kde.org/r/123315/diff/
> 
> 
> Testing
> -------
> 
> Can still export both into JPG and PNG, and still import from SVG and SVGZ in Karbon.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150411/fde21418/attachment.htm>