Review Request 123295: Kexi find dialog size improvements.
Jarosław Staniek
staniek at kde.org
Thu Apr 9 17:31:39 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123295/#review78717
-----------------------------------------------------------
Almost OK!
kexi/main/kexifinddialog.cpp (line 127)
<https://git.reviewboard.kde.org/r/123295/#comment53863>
+ check if !QRect::isEmpty()
- Jarosław Staniek
On April 9, 2015, 2:52 p.m., Roman Shtemberko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123295/
> -----------------------------------------------------------
>
> (Updated April 9, 2015, 2:52 p.m.)
>
>
> Review request for Calligra, Adam Pigg, Jarosław Staniek, Radosław Wicik, and Wojciech Kosowicz.
>
>
> Bugs: 345689
> http://bugs.kde.org/show_bug.cgi?id=345689
>
>
> Repository: calligra
>
>
> Description
> -------
>
> Dialog opens with minimu size possible and saves it's position and geometry using KConfig on close.
> Widgets rearanged a bit to take less space.
>
>
> Diffs
> -----
>
> kexi/main/kexifinddialog.cpp ffa6a8e
> kexi/main/kexifinddialog.ui 7a4c38f
>
> Diff: https://git.reviewboard.kde.org/r/123295/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Roman Shtemberko
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150409/4adcc2cd/attachment.htm>
More information about the calligra-devel
mailing list