Review Request 123295: Kexi find dialog size improvements.

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123295/#review78669
-----------------------------------------------------------



kexi/main/kexifinddialog.cpp (line 283)
<https://git.reviewboard.kde.org/r/123295/#comment53836>

    Isn't it redundant to the line 289?



kexi/main/kexifinddialog.cpp (line 295)
<https://git.reviewboard.kde.org/r/123295/#comment53837>

    If closing does not destroy the dialog, perhaps it's enough to read the geometry in its constructor and save it in the destructor.



kexi/main/kexifinddialog.ui 
<https://git.reviewboard.kde.org/r/123295/#comment53838>

    It seems these widgets are no longer in the tab order list, no idea why Designer did that. Let's see if everything's fine in real use or using the tab order tool of Designer.


- Jarosław Staniek


On April 8, 2015, 3:24 p.m., Roman Shtemberko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123295/
> -----------------------------------------------------------
> 
> (Updated April 8, 2015, 3:24 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg, Jarosław Staniek, Radosław Wicik, and Wojciech Kosowicz.
> 
> 
> Bugs: 345689
>     http://bugs.kde.org/show_bug.cgi?id=345689
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Dialog opens with minimu size possible and saves it's position and geometry using KConfig on close.
> Widgets rearanged a bit to take less space.
> 
> 
> Diffs
> -----
> 
>   kexi/main/kexifinddialog.h 4f400ba 
>   kexi/main/kexifinddialog.cpp ffa6a8e 
>   kexi/main/kexifinddialog.ui 7a4c38f 
> 
> Diff: https://git.reviewboard.kde.org/r/123295/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Roman Shtemberko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150408/6a586e4d/attachment.htm>