How to share KoUnit?

[Jaroslaw Staniek]

On 7 April 2015 at 08:50, Adam Pigg <piggz1 at gmail.com> wrote:
> I think KoPageformat can be replaced with some Qt funtionality, qpagesize was added in 5.3.

OK
If so please investigate if we have all we need without regression in
behaviour and the file format.

> Kodpi is a very small wrapper to get the spirit, so we could get rid of it in reports of needed, or remove the bits we don't use.

Looks good, proposed location is some namespace KReportUtils { }, keep
it not exported as I see no use of the KoDpi in headers.

(similar to KPropertyUtils in KProperty)

Applies to KoUnit too.

>
> Sent from my BlackBerry 10 smartphone.
>   Original Message
> From: Boudewijn Rempt
> Sent: Tuesday, 7 April 2015 7:19 AM
> To: Calligra Suite developers and users mailing list
> Reply To: Calligra Suite developers and users mailing list
> Subject: Re: How to share KoUnit?
>
> I'd say, keep a copy until at least 3.0 is done. Before that, I really
> wouldn't like to start splitting out libraries from the git repo. It's
> going to be hard enough already to make the kf5 port work out.
>
> On Mon, 6 Apr 2015, Jaroslaw Staniek wrote:
>
>> Hi,
>> For a good reason internal format of Kexi Report documents is modelled
>> after ODF specs. [0]
>> In particular units are. So in Calligra 2.x we started to use KoUnit
>> in libs/koreport and, by extension, in libs/koproperty.
>>
>> Now it's not that easy after recent extracting both to KReport [1] and
>> KProperty [2] frameworks, respectively. For now both frameworks have a
>> copy of KoUnit, which is ugly and soon will be unusable because they
>> should share one.
>>
>> Would you think it's time to start having a part of the ODF lib in a
>> separate repo. Who's going to maintain it?
>> From the point of view of the entire suite, the above story isn't too important.
>>
>> The issue of sharing the code between KProperty and KReport would be
>> solved by offering the shared classes in KProperty.
>> But interesting bit is then that Kexi would use these copies
>> (naturally, KoUnit renamed to something else, etc.) instead of the
>> originals from calligra/libs/.
>>
>> Ideas?
>>
>> PS: Similar challenge applies to KoLineStyleSelector, KoPageFormat,
>> KoDpi, KoRuler, KoViewConverter, KoZoomMode, KoZoomHandler.
>>
>> [0] https://community.kde.org/Kexi/Plugins/Reports/Fileformat
>> [1] https://community.kde.org/Kexi/Porting_to_Qt%26KF_5#kreport
>> [2] https://community.kde.org/Kexi/Porting_to_Qt%26KF_5#kproperty
>>
>> --
>> regards, Jaroslaw Staniek
>>
>> KDE:
>> : A world-wide network of software engineers, artists, writers, translators
>> : and facilitators committed to Free Software development - http://kde.org
>> Calligra Suite:
>> : A graphic art and office suite - http://calligra.org
>> Kexi:
>> : A visual database apps builder - http://calligra.org/kexi
>> Qt Certified Specialist:
>> : http://www.linkedin.com/in/jstaniek
>> _______________________________________________
>> calligra-devel mailing list
>> calligra-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/calligra-devel
> _______________________________________________
> calligra-devel mailing list
> calligra-devel at kde.org
> https://mail.kde.org/mailman/listinfo/calligra-devel
> _______________________________________________
> calligra-devel mailing list
> calligra-devel at kde.org
> https://mail.kde.org/mailman/listinfo/calligra-devel



-- 
regards, Jaroslaw Staniek

KDE:
: A world-wide network of software engineers, artists, writers, translators
: and facilitators committed to Free Software development - http://kde.org
Calligra Suite:
: A graphic art and office suite - http://calligra.org
Kexi:
: A visual database apps builder - http://calligra.org/kexi
Qt Certified Specialist:
: http://www.linkedin.com/in/jstaniek