Review Request 122867: Replace deprecated strstream classes with sstreams in Quattro Pro filter

[Inge Wallin]

On Sunday, April 05, 2015 12:00:35 PM Boudewijn Rempt wrote:
> > On March 10, 2015, 4:35 a.m., Thorsten Zachmann wrote:
> > > The patch looks good to me.
> > 
> > Robert Mathias Marmorstein wrote:
> >     I downloaded the tests from calligratests, but haven't been able to
> >     get the QPro plugin to work well enough to test this at all.  I'm
> >     really hesitant to commit without further testing.  To be completely
> >     frank, this plugin seems to be in pretty bad shape.  Someone with
> >     more experience than me should probably look it over and decide if
> >     it's worth keeping.> 
> > Camilla Boemann wrote:
> >     I don't think anyone around knows this filter better than you would,
> >     and if you cant find any sampe qpro files on the web then we will
> >     just have to hope for the best i guess
> If the filter is essentially untestable because there are no more files out
> in the wild to test with, then I'd agree that removing it is the best
> option.

First: This is not what she wrote so there is nothing like that to agree with.

Second: put "filetype: qpro" into a google search gives at least a few hits.  
But I am astonished how few they are. But at least something to try with. 
There are also a few qpro files in the test suite if I remember correctly.

A blog post asking for samples would probably also give some results.


> - Boudewijn
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122867/#review77243
> -----------------------------------------------------------
> 
> On March 9, 2015, 11:52 a.m., Robert Mathias Marmorstein wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://git.reviewboard.kde.org/r/122867/
> > -----------------------------------------------------------
> > 
> > (Updated March 9, 2015, 11:52 a.m.)
> > 
> > 
> > Review request for Calligra.
> > 
> > 
> > Repository: calligra
> > 
> > 
> > Description
> > -------
> > 
> > The strstream class has been deprecated for some time in favor of the
> > sstream classes.  This patch replaces strstream with sstreams.
> > 
> > 
> > Diffs
> > -----
> > 
> >   filters/sheets/qpro/libqpro/src/formula.cc c5d6021
> >   filters/sheets/qpro/libqpro/src/record.cc bde5e7d
> >   filters/sheets/qpro/libqpro/src/stream.cc 4126aee
> > 
> > Diff: https://git.reviewboard.kde.org/r/122867/diff/
> > 
> > 
> > Testing
> > -------
> > 
> > After the change calligra compiles and passes the same unit tests as
> > before.  Unfortunately, I don't have any qpro files lying around to test
> > this on.
> > 
> > 
> > Thanks,
> > 
> > Robert Mathias Marmorstein