Review Request 123243: Krita - Improve SliderSpinBox when used in plastique style
Moritz Molch
kde at moritzmolch.de
Fri Apr 3 20:57:31 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123243/
-----------------------------------------------------------
Review request for Calligra.
Repository: calligra
Description
-------
The SliderSpinBox doesn't look very good when used in the Plastique style. See the attached image for a comparison. This patch adds some quirks for the plastique style. It's always kind of a hazzle to make custom widgets work 100% correctly with a bunch of styles when drawing controls but that's the price that has to be paid when manually painting widgets...
Diffs
-----
krita/ui/widgets/kis_slider_spin_box.h 3762250
krita/ui/widgets/kis_slider_spin_box.cpp 83db96f
Diff: https://git.reviewboard.kde.org/r/123243/diff/
Testing
-------
Tested on Ubuntu 14.04
File Attachments
----------------
Comparison old vs. new
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/03/988fbaac-befa-46cd-86f9-9a03e27326bd__plastique_slider2.png
Thanks,
Moritz Molch
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150403/2287a444/attachment.htm>
More information about the calligra-devel
mailing list