Review Request 120375: Don't look further than what we are currently layouting

[Camilla Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120375/#review67471
-----------------------------------------------------------

Ship it!


great work !!!

i am sure you nailed it with this

- Camilla Boemann


On Sept. 25, 2014, 10:11 p.m., Pierre Ducroquet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120375/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2014, 10:11 p.m.)
> 
> 
> Review request for Calligra and Camilla Boemann.
> 
> 
> Bugs: 332220
>     http://bugs.kde.org/show_bug.cgi?id=332220
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Don't look further than what we are currently layouting
> 
> 
> Diffs
> -----
> 
>   libs/textlayout/KoTextDocumentLayout.cpp 3c869e017265e3776812e8ece5ee67ecfb275e48 
> 
> Diff: https://git.reviewboard.kde.org/r/120375/diff/
> 
> 
> Testing
> -------
> 
> Fix bug 332220 by not looking for annotations after the line we are currently layouting. Since we are currently layouting it, we crash trying to use the next line if we go to far.
> 
> Testing done on :
> - the two test cases for bug 332220 : no more crash, comment still visible.
> - a simple non-crashing file : no crash, comment still visible.
> 
> 
> Thanks,
> 
> Pierre Ducroquet
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140926/dc45e24e/attachment.htm>