Review Request 120348: Krita: Add unit of measurement to brush size and remove precision

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120348/#review67411
-----------------------------------------------------------

Ship it!


I would agree with both changes. I've checked other applications and all seem to have integer precision for brush size.

- Boudewijn Rempt


On Sept. 24, 2014, 3:09 a.m., Scott Petrovic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120348/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2014, 3:09 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> It is helpful when numbers have a context for them (ie px). I am also not sure how valuable values like 45.24 are with brush sizes. I think not using floats is easier to read and has little impact on painting.
> 
> 
> Diffs
> -----
> 
>   krita/plugins/paintops/libpaintop/kis_auto_brush_widget.cpp 42ffe23 
>   krita/plugins/paintops/libpaintop/kis_brush_chooser.cpp 3bd7aa6 
>   krita/ui/kis_paintop_box.cc 9a22571 
> 
> Diff: https://git.reviewboard.kde.org/r/120348/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Scott Petrovic
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140925/51afe63c/attachment.htm>