Review Request 120344: Krita: Show bounds better for curves widget

Boudewijn Rempt boud at valdyas.org
Thu Sep 25 12:35:39 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120344/#review67409
-----------------------------------------------------------


Ah, this break filters like the color curves -- because now the fillRect unconditionally paints over the pixmap, if there's one set. If you move the fill line to above the block that paints the pixmap, the patch is fine.

- Boudewijn Rempt


On Sept. 24, 2014, 2:50 a.m., Scott Petrovic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120344/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2014, 2:50 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Always show background color on curves widget to help frame it
> 
> 
> Diffs
> -----
> 
>   krita/ui/widgets/kis_curve_widget.cpp 64a7582 
> 
> Diff: https://git.reviewboard.kde.org/r/120344/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Scott Petrovic
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140925/98ba1b5c/attachment.htm>


More information about the calligra-devel mailing list