Review Request 120272: Support the scrollwheel in KexiRecordNavigator

Jarosław Staniek staniek at kde.org
Tue Sep 23 00:10:49 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120272/#review67246
-----------------------------------------------------------


Almost ready, minor things. 

+ when I scroll the wheel over a disabled navigator button, my action has no effect. Do we need an event filter?


kexi/widget/utils/kexirecordnavigator.cpp
<https://git.reviewboard.kde.org/r/120272/#comment46928>

    How about we're removing the Qt::WheelFocus from focusPolicy? Would this avoid stealing the focus?


- Jarosław Staniek


On Sept. 18, 2014, 9:40 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120272/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2014, 9:40 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Scroll wheel up is translates to previous button, while scroll wheel down is to next.
> Matches behaviour found in other navigator places, where down means next and up previous.
> (That is different from behaviour in value entering fields, where up means bigger numbers and down means smaller numbers)
> 
> Which bug report was this requested in? Could not find one yet.
> 
> 
> Diffs
> -----
> 
>   kexi/widget/utils/kexirecordnavigator.h a9a5e12 
>   kexi/widget/utils/kexirecordnavigator.cpp 1836d21 
> 
> Diff: https://git.reviewboard.kde.org/r/120272/diff/
> 
> 
> Testing
> -------
> 
> Tested both with record navigation and with page navigation in reports.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140922/0c3c615c/attachment.htm>


More information about the calligra-devel mailing list