Review Request 120310: Improve widget properties translation

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120310/#review67243
-----------------------------------------------------------


Cool, some more notes added that would ideally be adressed in this patch.


kexi/formeditor/form.cpp
<https://git.reviewboard.kde.org/r/120310/#comment46920>

    The checkSpellingEnabled property is specific to KTextEdit, so it would belong to factory that defined this widget. In form.cpp we're mostly looking at properties of QWidget. Use setPropertyDescription() for that. Maybe setValueDescription().



kexi/formeditor/form.cpp
<https://git.reviewboard.kde.org/r/120310/#comment46922>

    - The same note as above
    - in such cases use i18nc("Widget Property", "HTML") for better clarity



kexi/formeditor/form.cpp
<https://git.reviewboard.kde.org/r/120310/#comment46923>

    BTW, layoutDirection is marked as advanced - grep for advancedProperties.insert("layoutDirection") -  hence it's hidden, this means translation is not needed, please remove



kexi/formeditor/form.cpp
<https://git.reviewboard.kde.org/r/120310/#comment46924>

    The property is specific to QTextEdit, note as above.



kexi/formeditor/form.cpp
<https://git.reviewboard.kde.org/r/120310/#comment46925>

    The property is specific to QTextEdit, note as above.



kexi/formeditor/form.cpp
<https://git.reviewboard.kde.org/r/120310/#comment46926>

    BTW, let's hide this property using  advancedProperties.insert("sizePolicy") in 
    WidgetLibraryPrivate(); sizePolicy is useful with layouts but we don't support them.



kexi/formeditor/form.cpp
<https://git.reviewboard.kde.org/r/120310/#comment46927>

    The property is specific to KTextEdit, note as above.


- Jarosław Staniek


On Sept. 23, 2014, 12:14 a.m., Michal Poteralski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120310/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2014, 12:14 a.m.)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Jarosław Staniek, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz.
> 
> 
> Bugs: 339246
>     http://bugs.kde.org/show_bug.cgi?id=339246
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Improve widget properties translation.
> 
> There are a few issues with translation for widget properties for Forms.
> This patch fixes untranslated widget properties.
> 
> 
> Diffs
> -----
> 
>   kexi/formeditor/form.h c8f8b3e 
>   kexi/formeditor/form.cpp f45f207 
> 
> Diff: https://git.reviewboard.kde.org/r/120310/diff/
> 
> 
> Testing
> -------
> 
> I've tested on kexi and works well. 
> 
> 
> Thanks,
> 
> Michal Poteralski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140922/65d38fdb/attachment.htm>