Review Request 120310: Improve widget properties translation

Jarosław Staniek staniek at kde.org
Mon Sep 22 22:55:46 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120310/#review67237
-----------------------------------------------------------


Good code fixing the fore/back color name. As discussed on IRC however, let's not sort the properties; sorting and (one day) grouping is handled elsewhere.

Also since today any patch shall be made agains master; 2.8 is closed now.


kexi/formeditor/form.cpp
<https://git.reviewboard.kde.org/r/120310/#comment46917>

    So btw, title -> Title (my bug)



kexi/formeditor/form.cpp
<https://git.reviewboard.kde.org/r/120310/#comment46918>

    this line not needed, just use "paletteBackgroundColor" and compiler would optimize it :)



kexi/formeditor/form.cpp
<https://git.reviewboard.kde.org/r/120310/#comment46919>

    like above


- Jarosław Staniek


On Sept. 22, 2014, 12:22 a.m., Michal Poteralski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120310/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2014, 12:22 a.m.)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Jarosław Staniek, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz.
> 
> 
> Bugs: 339246
>     http://bugs.kde.org/show_bug.cgi?id=339246
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Improve widget properties translation.
> 
> There are a few issues with translation for widget properties for Forms.
> This patch fixes untranslated widget properties.
> 
> 
> Diffs
> -----
> 
>   kexi/formeditor/form.cpp f45f207 
> 
> Diff: https://git.reviewboard.kde.org/r/120310/diff/
> 
> 
> Testing
> -------
> 
> I've tested on kexi and works well. 
> 
> 
> Thanks,
> 
> Michal Poteralski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140922/c8262026/attachment.htm>


More information about the calligra-devel mailing list