Review Request 120209: Remove unused Find*.cmake scripts

Lukáš Tvrdý lukast.dev at gmail.com
Sun Sep 21 20:27:02 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120209/#review67158
-----------------------------------------------------------

Ship it!


Well, go ahead I would say!

- Lukáš Tvrdý


On Sept. 14, 2014, 10:17 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120209/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2014, 10:17 p.m.)
> 
> 
> Review request for Calligra, Cyrille Berger Skott, Camilla Boemann, Stuart Dickson, and Boudewijn Rempt.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Seems these 6 Find*.cmake scripts are no longer used. So I propose to remove them.
> 
> FindDCMTK.cmake: forgotten to be removed in 44a9df40fe8e604e56d75d68e51f39198c130d58
> FindGIF2.cmake: forgotten to be removed in e891dace2586104ad6fd08c7cf7c0e56d37b3a16
> FindGLPK.cmake: required for the painterlymixer for unknown reason, which no longer exists (for what I saw)
> FindGMM.cmake: forgotten to be removed in 8c0aa949162f9e2ec4da0874815025782ad261f2 ()
> FindKunittest.cmake: this is kde3-times stuff, no longer in use
> FindLIBGSF.cmake: forgotten to be removed in 65e29251823fcaa8878dc0ab917d53581437cc0b
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindDCMTK.cmake 54ae377 
>   cmake/modules/FindGIF2.cmake 0bf410c 
>   cmake/modules/FindGLPK.cmake d2cd178 
>   cmake/modules/FindGMM.cmake 5049c64 
>   cmake/modules/FindKunittest.cmake 331d0e2 
>   cmake/modules/FindLIBGSF.cmake 8d749a8 
> 
> Diff: https://git.reviewboard.kde.org/r/120209/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140921/2434ca27/attachment.htm>


More information about the calligra-devel mailing list