Review Request 120294: Many fixes for Kexi database import assistant

[Jarosław Staniek]

> On Sept. 20, 2014, 10:26 p.m., Michal Poteralski wrote:
> > kexi/migration/importwizard.cpp, line 102
> > <https://git.reviewboard.kde.org/r/120294/diff/1/?file=313646#file313646line102>
> >
> >     We don't need dstServerTypeCombo any longer.

Good catch, removed srcTypeCombo too.


> On Sept. 20, 2014, 10:26 p.m., Michal Poteralski wrote:
> > kexi/migration/importwizard.cpp, line 1010
> > <https://git.reviewboard.kde.org/r/120294/diff/1/?file=313646#file313646line1010>
> >
> >     More meaningful name than "ok" should be better :)

true but this is widely used convention for local 'success' flag


> On Sept. 20, 2014, 10:26 p.m., Michal Poteralski wrote:
> > kexi/migration/importwizard.cpp, line 1026
> > <https://git.reviewboard.kde.org/r/120294/diff/1/?file=313646#file313646line1026>
> >
> >     Should we leave unused commented code? If not, please remove.

Yes, I am not 100% sure for now what to do with these bits so keeping them for some time.


- Jarosław


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120294/#review67083
-----------------------------------------------------------


On Sept. 20, 2014, 2:06 a.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120294/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2014, 2:06 a.m.)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz.
> 
> 
> Bugs: 336556, 336557 and 336558
>     http://bugs.kde.org/show_bug.cgi?id=336556
>     http://bugs.kde.org/show_bug.cgi?id=336557
>     http://bugs.kde.org/show_bug.cgi?id=336558
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Many fixes for Kexi database import assistant
> 
> * Import Database" assistant may require password to access
>   source or destination server but it does not ask. Then connection
>   error appears.
> * reload source database list if user pressed back and selected different connection
> * improve saving recent directories
> * do not ask twice about destination filename
> * in addition to title, properly ask for database name for server destination databases
> * properly open imported database (file)
> 
> 
> Diffs
> -----
> 
>   kexi/widget/KexiDBTitlePage.ui 14b811ee8e06733df1bfdd14829befaec12e000e 
>   kexi/main/startup/KexiNewProjectAssistant.cpp c016cfc2c56f5cb7d6eeb2ebdfe71b3dff8969f6 
>   kexi/main/startup/KexiStartupFileHandler.h ee0ecc0c87c499a1753c803098621201050c4f97 
>   kexi/main/startup/KexiStartupFileHandler.cpp 2eb6b21534b3bac78792dce8c4e08c3b47cc2508 
>   kexi/migration/CMakeLists.txt b84ad51694f627870fff2d69ec3f71427982f87b 
>   kexi/migration/importwizard.h ce328168d9643115aade796647689dd1159331fe 
>   kexi/migration/importwizard.cpp 7cbea8165ba97ecce67c77b4d25dca1c0a088485 
> 
> Diff: https://git.reviewboard.kde.org/r/120294/diff/
> 
> 
> Testing
> -------
> 
> tested all combinations of server/file import
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140920/d0b0c017/attachment.htm>