Review Request 120033: Multiple map elements render in reports.

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120033/#review67085
-----------------------------------------------------------


I have marble-devel-4.11.5-186 here, still there's a build error. If my marble version isn't ok, it shall be detected.

calligra-2.8/plugins/reporting/maps/KoReportItemMaps.cpp: In member function ‘void KoReportItemMaps::onRenderStatusChange()’:
calligra-2.8/plugins/reporting/maps/KoReportItemMaps.cpp:175:5: error: ‘RenderStatus’ is not a member of ‘Marble’
     Marble::RenderStatus status = marbleWidget->renderStatus();
     ^
calligra-2.8/plugins/reporting/maps/KoReportItemMaps.cpp:175:26: error: expected ‘;’ before ‘status’
     Marble::RenderStatus status = marbleWidget->renderStatus();
                          ^
calligra-2.8/plugins/reporting/maps/KoReportItemMaps.cpp:176:63: error: ‘status’ was not declared in this scope
     myDebug() << "sender(): " << sender() << " | status: " << status;
                                                               ^
calligra-2.8/plugins/reporting/maps/KoReportItemMaps.cpp:178:8: error: ‘status’ was not declared in this scope
     if(status == Marble::Complete){
        ^
calligra-2.8/plugins/reporting/maps/KoReportItemMaps.cpp:178:18: error: ‘Complete’ is not a member of ‘Marble’
     if(status == Marble::Complete){
                  ^
gmake[2]: *** [plugins/reporting/maps/CMakeFiles/koreport_mapsplugin.dir/KoReportItemMaps.cpp.o] Error 1


% marble --version
Qt: 4.8.5
KDE Development Platform: 4.14.1
Marble Virtual Globe: 1.6.5 (stable version)

- Jarosław Staniek


On Sept. 1, 2014, 11:42 p.m., Radosław Wicik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120033/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2014, 11:42 p.m.)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Jarosław Staniek, Dimitrios Tanis, and Tomasz Olszak.
> 
> 
> Bugs: 336986
>     http://bugs.kde.org/show_bug.cgi?id=336986
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Multiple map elements render in reports.
> 
> BUG:336986
> 
> 
> Diffs
> -----
> 
>   plugins/reporting/maps/KoReportItemMaps.h 060ff3744de39806ac3b7873f253e72036bc96a3 
>   plugins/reporting/maps/KoReportItemMaps.cpp 86133eb0469787d84887542b989428ea3e9a63b0 
> 
> Diff: https://git.reviewboard.kde.org/r/120033/diff/
> 
> 
> Testing
> -------
> 
> manually tested
> 
> 
> Thanks,
> 
> Radosław Wicik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140920/03fd61c8/attachment.htm>