Review Request 120274: Add Qsort comparator (for Strings) which uses Collator.

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120274/#review66867
-----------------------------------------------------------


Works great! Minor fixes needed.


libs/db/CMakeLists.txt
<https://git.reviewboard.kde.org/r/120274/#comment46623>

    ${ICU_INCLUDE_DIRS} needed I guess like in libs/db/drivers/sqlite/icu
    
    The reason why it works for you is that you have the dir included for other libs.



libs/db/tableviewdata.cpp
<https://git.reviewboard.kde.org/r/120274/#comment46630>

    use K_GLOBAL_STATIC (from KGlobal) so the object gets destroyed on app's exit



libs/db/tableviewdata.cpp
<https://git.reviewboard.kde.org/r/120274/#comment46625>

    try to use single expression for 134..138



libs/db/tableviewdata.cpp
<https://git.reviewboard.kde.org/r/120274/#comment46648>

    Since this is "lessThan" function I think you should use LESS here. Noticed that after testing our sample db.



libs/db/tableviewdata.cpp
<https://git.reviewboard.kde.org/r/120274/#comment46626>

    coding standards: missing space



libs/db/tableviewdata.cpp
<https://git.reviewboard.kde.org/r/120274/#comment46627>

    - use kWarning() << ...
    - don't you want to return false here?



libs/db/tableviewdata.cpp
<https://git.reviewboard.kde.org/r/120274/#comment46632>

    when you port to K_GLOBAL_STATIC you will use m_collator->exists() here


- Jarosław Staniek


On Sept. 18, 2014, 10:29 p.m., Michal Poteralski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120274/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2014, 10:29 p.m.)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Jarosław Staniek, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz.
> 
> 
> Bugs: 338808
>     http://bugs.kde.org/show_bug.cgi?id=338808
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Add Qsort comparator (for Strings) which uses Collator.
> 
> Actualy there is only unicode string comparator for Strings.
> The patch implements String comparator which uses Collator.
> 
> 
> Diffs
> -----
> 
>   libs/db/CMakeLists.txt aad1c25 
>   libs/db/tableviewdata.cpp a87c1b2 
> 
> Diff: https://git.reviewboard.kde.org/r/120274/diff/
> 
> 
> Testing
> -------
> 
> I've tested on Kexi and works well. 
> 
> 
> Thanks,
> 
> Michal Poteralski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140918/2e920c34/attachment.htm>