Review Request 120250: Don't infinitely loop when backtracking keepWithNext with a page break

[Pierre Ducroquet]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120250/
-----------------------------------------------------------

(Updated Sept. 18, 2014, 7:41 p.m.)


Review request for Calligra.


Changes
-------

Don't backtrack one step too much


Bugs: 306000
    http://bugs.kde.org/show_bug.cgi?id=306000


Repository: calligra


Description
-------

The backtrack code can infinitely loop when encounteering a page break in a long keepWithNext block.

With that patch, we still have a difference between us and LibreOffice 4.3 : they decide to just skip the page break when it is in a keep with next block.


Diffs (updated)
-----

  libs/textlayout/KoTextLayoutArea.cpp c74dbd4 

Diff: https://git.reviewboard.kde.org/r/120250/diff/


Testing
-------

Checked with the document from bug report 306000 : layouting the document now works and does not end up in an infinite loop.


Thanks,

Pierre Ducroquet

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140918/f2f0deac/attachment.htm>