Review Request 120042: Remove traces of unused KXMLGUI from Kexi

Jarosław Staniek staniek at kde.org
Tue Sep 16 00:50:53 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120042/
-----------------------------------------------------------

(Updated Sept. 15, 2014, 11:50 p.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra, Andrius da Costa Ribas, Friedrich W. H. Kossebau, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz.


Repository: calligra


Description
-------

Remove traces of unused KXMLGUI from Kexi

Kexi 2 does not depend on KXMLGUI since it replaces dynamic menus with dynamic tabbed toolbar.

This cleanup may remove crashes on closing Kexi windows.


Diffs
-----

  kexi/core/KexiMainWindowIface.h cf39916 
  kexi/core/kexiactionproxy.h 695e983 
  kexi/core/kexiactionproxy.cpp 8cc64ce 
  kexi/core/kexiactionproxy_p.h 88991f6 
  kexi/core/kexipart.cpp f5c40f9 
  kexi/core/kexipartguiclient.h 5f52ec5 
  kexi/core/kexisharedactionhost.cpp b0f851e 
  kexi/main/KexiMainWindow.h eac4fb4 
  kexi/main/KexiMainWindow.cpp c5ed012 
  kexi/main/KexiMainWindow_p.h 0db7456 
  kexi/mobile/KexiMobileMainWindow.h 9f3eabd 
  kexi/mobile/KexiMobileMainWindow.cpp 352bae8 
  kexi/plugins/scripting/kexiscripting/kexiscriptpart.cpp 797f2c0 

Diff: https://git.reviewboard.kde.org/r/120042/diff/


Testing
-------

Shared actions still work


Thanks,

Jarosław Staniek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140915/3166c24b/attachment.htm>


More information about the calligra-devel mailing list