Review Request 120128: [Kexi] Fix for regression in Reports

[Wojciech Kosowicz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120128/
-----------------------------------------------------------

(Updated Sept. 10, 2014, 2:33 p.m.)


Review request for Calligra, Friedrich W. H. Kossebau, Adam Pigg, and Jarosław Staniek.


Changes
-------

* two mistakes corrected
@staniek please take care of uploading(correcting) this patch to master and calligra/2.8


Bugs: 338941
    http://bugs.kde.org/show_bug.cgi?id=338941


Repository: calligra


Description
-------

One of previous commits introduced regression. After turning on kexi and report that was saved before elements were in 0,0 position and default size. There was also a crash. Turned out that init method was called when opening saved report. Previosuly it contained lines that were calling null pointer and repainting the element in 0,0 position with default size


Diffs (updated)
-----

  libs/koreport/wrtembed/KoReportDesignerItemLine.cpp 1ef9369 
  libs/koreport/wrtembed/KoReportDesignerItemRectBase.cpp 11906f4 
  plugins/reporting/barcode/KoReportDesignerItemBarcode.cpp a0415e2 
  plugins/reporting/maps/KoReportDesignerItemMaps.cpp e5d5503 
  plugins/reporting/web/KoReportDesignerItemWeb.cpp b8628ae 
  libs/koreport/items/check/KoReportDesignerItemCheck.cpp e6ff156 
  libs/koreport/items/field/KoReportDesignerItemField.cpp 54b96d5 
  libs/koreport/items/image/KoReportDesignerItemImage.cpp fb2ad71 
  libs/koreport/items/label/KoReportDesignerItemLabel.cpp 4cd7df4 
  libs/koreport/items/text/KoReportDesignerItemText.cpp 664ef60 
  libs/koreport/wrtembed/KoReportDesigner.h 32f5687 
  libs/koreport/wrtembed/KoReportDesigner.cpp 4340bad 

Diff: https://git.reviewboard.kde.org/r/120128/diff/


Testing
-------

Create report with different element and different sizes. Save it, close Kexi, start it open saved report go to design view. It should not crash and everything should be as before save


Thanks,

Wojciech Kosowicz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140910/719f2403/attachment.htm>