Review Request 120112: Fix crash in report designer (properly check for m_detail)

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120112/
-----------------------------------------------------------

(Updated Sept. 9, 2014, 1:07 p.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra, Adam Pigg, Jarosław Staniek, and Wojciech Kosowicz.


Repository: calligra


Description
-------

Latest Kexi master crashes for me when going to Design mode with reports.

Reason is that existance of m_detail is not properly checked for everywhere. Guess only some recent changes outside of KoReportDesigner are triggering these crashes now, as this code is quite old.

No idea if that is a problem in 2.8, at least I have not seen this problem in master ever before. Still by the code it might make sense to backport it. Needs somebody who runs 2.8, though, I don't have that.


Diffs
-----

  libs/koreport/wrtembed/KoReportDesigner.cpp 8e107bf 

Diff: https://git.reviewboard.kde.org/r/120112/diff/


Testing
-------

No longer crashes with my test files.


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140909/e4ce8117/attachment.htm>