Review Request 120083: Fixup for normalization of signals

Jarosław Staniek staniek at kde.org
Sun Sep 7 22:56:00 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120083/#review66016
-----------------------------------------------------------

Ship it!


Good catch!

- Jarosław Staniek


On Sept. 7, 2014, 12:16 a.m., Wojciech Kosowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120083/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2014, 12:16 a.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Commit 32dd821a55ce36a7dedfc9f81b56d4c93f6fbbe4 introduced problems with signal. This commit is partially revert of it. With keeping all the changes that were right
> 
> 
> Diffs
> -----
> 
>   plugins/reporting/maps/KoReportDesignerItemMaps.cpp 4aaf6cf 
>   libs/koreport/wrtembed/KoReportDesigner.cpp 9d7f5f4 
>   libs/koreport/wrtembed/KoReportDesignerItemLine.cpp 7cf04fc 
>   libs/koreport/wrtembed/reportsection.cpp 4749a86 
>   plugins/reporting/barcode/KoReportDesignerItemBarcode.cpp ea51be8 
>   plugins/reporting/chart/KoReportDesignerItemChart.cpp 2f45f8a 
>   libs/koreport/renderer/KoReportPreRenderer.cpp 51055f5 
>   plugins/reporting/web/KoReportDesignerItemWeb.cpp bc4bc29 
>   libs/koproperty/EditorView.cpp d074c34 
>   libs/koproperty/Set.cpp 51992c9 
>   libs/koreport/items/check/KoReportDesignerItemCheck.cpp d49769c 
>   libs/koreport/items/field/KoReportDesignerItemField.cpp 0cc7240 
>   libs/koreport/items/image/KoReportDesignerItemImage.cpp 5994d2a 
>   libs/koreport/items/label/KoReportDesignerItemLabel.cpp 778f8ab 
>   libs/koreport/items/text/KoReportDesignerItemText.cpp a8ee4a8 
> 
> Diff: https://git.reviewboard.kde.org/r/120083/diff/
> 
> 
> Testing
> -------
> 
> Line element of Report Design gets appears after being painted
> 
> 
> Thanks,
> 
> Wojciech Kosowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140907/53136186/attachment.htm>


More information about the calligra-devel mailing list