Review Request 120011: Let Ctrl+Home/Ctrl+End go to top and bottom of text shape in stage.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120011/
-----------------------------------------------------------

(Updated Sept. 4, 2014, 5:52 p.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra, Sven Langkamp and Thorsten Zachmann.


Repository: calligra


Description
-------

Much more expected than exiting edit-mode and going to the first or last page.

This required to pass QEvent::ShortcutOverride event to tools, via viewmodes.
The name shortcutOverrideEvent() is made up, QWidget doesn't have a specific
virtual method for this and requires reimplementing event(QEvent*) instead.
But I find that shortcutOverrideEvent is much nicer to have :)

This new virtual method could be used to refine the earlier commits
which implemented some blind rule ("keys without modifiers or with shift"),
while the right way to do it is to accept the specific shortcuts handled
by the current tool (which can also include shortcuts with CTRL or even ALT,
and maybe does NOT include some shortcuts without modifiers, like PageUp or Esc...).
CCMAIL: sven.langkamp at gmail.com


Diffs
-----

  libs/flake/KoToolBase.h e84bd389a32af6cecb8a37be94010c0bebf70f4f 
  libs/flake/KoToolProxy.cpp 5dfd57ebfdc0f10eb1ce0e8a21e870ac69f79bb9 
  libs/kopageapp/KoPACanvasItem.h eb6b929bc24da248ddd5a62892030c2012957a32 
  libs/kopageapp/KoPACanvasItem.cpp 17790be4b1a64738a106b30eb7753278a8ae44d3 
  libs/kopageapp/KoPAViewMode.h 043b27c7273230d4dea368c2e2bc7a7dead2983f 
  libs/kopageapp/KoPAViewModeNormal.h 86b1e0422b7dfead2b47cee8858632a36fdc5d46 
  libs/kopageapp/KoPAViewModeNormal.cpp faba4dd9e6eda1ad7a4bc171b6f8e5d6ac0e1055 
  plugins/textshape/TextTool.h 340929215def4c254ec4c62bd7ffc140adf02ebf 
  plugins/textshape/TextTool.cpp 2bf8787816c100dbd7acde8ac730e91676a3ac41 
  stage/part/KPrViewModeNotes.h f1f008063c3c3f6e73349817161f9aa3f5cdc170 
  stage/part/KPrViewModeNotes.cpp 4cca0212e09c1b96a1bf864e8116eb96b35bf4f6 
  stage/part/KPrViewModePresentation.h 99d14dad95de9ac62b5cdb98c42c4040d0ee0488 
  stage/part/KPrViewModePresentation.cpp c72c59431a78c17574b1137881a2076fc17b2e24 
  stage/part/KPrViewModePreviewPageEffect.h 463502e23e6e02bb7a7f3748d9678aa3e9db4c13 
  stage/part/KPrViewModePreviewPageEffect.cpp a1bdf710bacd1ad669cab8518770e6494e8392b9 
  stage/part/KPrViewModePreviewShapeAnimations.h f1a234b3a54326715a13954e89826bd361df528c 
  stage/part/KPrViewModePreviewShapeAnimations.cpp c189a6d30252d5a8a152a3d08dd251b91d9bc83d 
  stage/part/KPrViewModeSlidesSorter.h 73014f896b35ee6096026263b4fc5c48670aff22 
  stage/part/KPrViewModeSlidesSorter.cpp 0d101cfeed010d1d41762c2a49521ee6a405e00f 
  libs/flake/KoToolBase.cpp 963dfad2c714f24ad34ae7cd09e8b2e3d457f7ae 
  libs/flake/KoToolProxy.h 6723c9c7c6e5404448d969606d267c72c5b0b3e6 

Diff: https://git.reviewboard.kde.org/r/120011/diff/


Testing
-------

Ctrl+Home/Ctrl+End in stage. Didn't test the other apps, but they should be unaffected.


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140904/39cd3622/attachment.htm>