Review Request 120042: Remove traces of unused KXMLGUI from Kexi

Jarosław Staniek staniek at kde.org
Wed Sep 3 00:42:33 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120042/
-----------------------------------------------------------

Review request for Calligra, Andrius da Costa Ribas, Friedrich W. H. Kossebau, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz.


Repository: calligra


Description
-------

Remove traces of unused KXMLGUI from Kexi

Kexi 2 does not depend on KXMLGUI since it replaces dynamic menus with dynamic tabbed toolbar.

This cleanup may remove crashes on closing Kexi windows.


Diffs
-----

  kexi/core/KexiMainWindowIface.h 1fa92f40774809b0625c12f731b75482930e285c 
  kexi/core/kexiactionproxy.h 7c039a00fb52b9cb7374bb3566db8f7e21ebd7dd 
  kexi/core/kexiactionproxy.cpp a284c792337f404dd4e88f1e47dfeb6055202fc1 
  kexi/core/kexiactionproxy_p.h 88991f681329e5efca7b7f9a161ed8a1608a7184 
  kexi/core/kexipart.cpp a68eae065f99d8ec4a3dfdf31ab8b0001bc2a5b7 
  kexi/core/kexipartguiclient.h 5f52ec514cddfefafd50cc3027080084eacc49a6 
  kexi/core/kexisharedactionhost.cpp 392e6c20940f60f1b846afd4d19a940e18b86452 
  kexi/core/kexisharedactionhost_p.h 69776656fb50b640cc8618ed2afe175c8b31dc18 
  kexi/formeditor/widgetfactory.h ce8cb19f07c6ba755f10bf9aaac3feee27ffc2c0 
  kexi/formeditor/widgetlibrary.cpp 46a64f6b64a5ea0e5542f3a5e89c3f92f9cca79c 
  kexi/main/KexiMainWindow.h 6e202f5601eeadd6bf6fc4be5a62bc79913ea583 
  kexi/main/KexiMainWindow.cpp 5006ee105f11962ec0dfd644b4075867b6d987ee 
  kexi/main/KexiMainWindow_p.h 89572137dd3475922b48a7c2d78690c5d12087c2 
  kexi/mobile/KexiMobileMainWindow.h 56a94f05cf9133aca001dc519208b4069d05f50f 
  kexi/mobile/KexiMobileMainWindow.cpp 64192c99ddee5fab15b29311f17a475c6dadbc49 
  kexi/plugins/scripting/kexiscripting/kexiscriptpart.cpp 95cbb6e98f59ba5db3c9e2c7748d4cbdb9efcd42 

Diff: https://git.reviewboard.kde.org/r/120042/diff/


Testing
-------

Shared actions still work


Thanks,

Jarosław Staniek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140902/7c0aeaee/attachment.htm>


More information about the calligra-devel mailing list