Review Request 120875: Krita - Fix proposal for brush speed sensor

[Damien de Lemeny]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120875/
-----------------------------------------------------------

(Updated Oct. 30, 2014, 8:08 a.m.)


Review request for Calligra.


Changes
-------

The smoothing code already exist in the sensor, simplify the patch.
Also, dummy implementation of a log scaled speed sensor, rationale in comment.


Repository: calligra


Description
-------

This patch intends to fix the broken speed sensor of the brush tool.

It's based on a patch I got from Wolthera, which was discarded/unfinished because the output of the sensor remained "blobby".

I added a smoothing formula to the speed output :

output_speed = current_speed * 0.1 + last_speed * 0.9


The used numeric values are either eyeballed or wild guessed from usage. There's certainly room for improvements on this patch.


Diffs (updated)
-----

  krita/plugins/paintops/libpaintop/sensors/kis_dynamic_sensors.cc 6b10e2b 

Diff: https://git.reviewboard.kde.org/r/120875/diff/


Testing
-------

I tested the ux of a speed bound preset before and after the patch and compared to the behaviour of a similar test brush in Mypaint.
Results are noticeable improvements when painting strokes at different speeds with the fix.

It's also been tested by Wolthera


Thanks,

Damien de Lemeny

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141030/6aa64fa5/attachment.htm>