Review Request 120766: Remove no longer used widget classes KoUniColorDialog & KoOpacityConfigWidget
Boudewijn Rempt
boud at valdyas.org
Fri Oct 24 12:02:44 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120766/#review69087
-----------------------------------------------------------
Ship it!
Yes, let's weed them out.
- Boudewijn Rempt
On Oct. 23, 2014, 9:05 p.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120766/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2014, 9:05 p.m.)
>
>
> Review request for Calligra, Camilla Boemann and Boudewijn Rempt.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> While checking the includes for classes from libkowidgets I found those two classes are no longer used by any code, so I propose to remove them as dead code.
>
> Last usage of KoUniColorDialog was removed in 53356cb20f1100edf716beba8c407953b3c692ec (by rempt)
> Last usage of KoOpacityConfigWidget was removed in 76242efb3bd5a116f034ef785c0a2e9e3608fc64 (by boemann)
>
>
> Diffs
> -----
>
> libs/widgets/CMakeLists.txt 324b762
> libs/widgets/KoOpacityConfigWidget.h 6fc81ef
> libs/widgets/KoOpacityConfigWidget.cpp 48d6395
> libs/widgets/KoUniColorDialog.h 4cce042
> libs/widgets/KoUniColorDialog.cpp 935b644
> plugins/defaultTools/defaulttool/DefaultTool.cpp f26d4bf
>
> Diff: https://git.reviewboard.kde.org/r/120766/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141024/10c0584e/attachment.htm>
More information about the calligra-devel
mailing list