Review Request 120659: Krita: save settings for gradient tool
Scott Petrovic
scottpetrovic at gmail.com
Wed Oct 22 02:41:00 BST 2014
> On Oct. 21, 2014, 11:53 p.m., Sven Langkamp wrote:
> > krita/plugins/tools/defaulttools/kis_tool_gradient.cc, line 287
> > <https://git.reviewboard.kde.org/r/120659/diff/1/?file=320744#file320744line287>
> >
> > Use kDebug with debug area here.
done. I removed the qDebug() line. That shouldn't have been committed in the first place. Thanks so much Sven for doing these code reviews. I appreciate it!
- Scott
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120659/#review68864
-----------------------------------------------------------
On Oct. 19, 2014, 5:46 p.m., Scott Petrovic wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120659/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2014, 5:46 p.m.)
>
>
> Review request for Calligra.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> load/save settings from kritarc file
>
>
> Diffs
> -----
>
> krita/plugins/tools/defaulttools/kis_tool_gradient.h b8de88d
> krita/plugins/tools/defaulttools/kis_tool_gradient.cc 6ffb0b5
>
> Diff: https://git.reviewboard.kde.org/r/120659/diff/
>
>
> Testing
> -------
>
> loading and saving. watching kritarc file update, and krita update.
>
>
> Thanks,
>
> Scott Petrovic
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141022/73a01c9b/attachment.htm>
More information about the calligra-devel
mailing list