Review Request 120653: Move KoRuler, KoRulerController and KoFontComboBox from komain to kowidgets

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120653/
-----------------------------------------------------------

(Updated Oct. 21, 2014, 6:44 p.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra.


Repository: calligra


Description
-------

Wigdets (and even more QWidget-based ones) make most sense if all collected in kowidgets, and not only some.
kowidgets already contains many widgets (which know about classes from kotext and flake).

So I propose to move KoRuler, KoRulerController and KoFontComboBox from komain to kowidgets. That way QML-based apps that use komain do not need to care about these classes. And koreport no longer needs to link to komain, but can "just" go with kowidgets and its deps.


Diffs
-----

  libs/widgets/KoRulerController.cpp PRE-CREATION 
  libs/widgets/KoRulerController_p.h PRE-CREATION 
  libs/widgets/KoRuler_p.h PRE-CREATION 
  libs/widgets/KoRuler.cpp PRE-CREATION 
  libs/widgets/KoRulerController.h PRE-CREATION 
  libs/koreport/CMakeLists.txt 3f648b7 
  libs/main/CMakeLists.txt 2affede 
  libs/main/KoFontComboBox.h 47d1550 
  libs/main/KoRuler.h 2c4875d 
  libs/main/KoRuler.cpp 6f49a1e 
  libs/main/KoRulerController.h 5543da7 
  libs/main/KoRulerController.cpp 9b433f4 
  libs/main/KoRulerController_p.h 1779972 
  libs/main/KoRuler_p.h 7c63e0a 
  libs/widgets/CMakeLists.txt 2268054 
  libs/widgets/KoFontComboBox.h PRE-CREATION 
  libs/widgets/KoRuler.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/120653/diff/


Testing
-------

Builds fine here.


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141021/8d19200b/attachment.htm>